Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in pass and fail, dur003 and ipd006 include p with no region #3

Closed
nigelmegitt opened this issue Nov 17, 2023 · 1 comment · Fixed by #5 or #6
Closed

in pass and fail, dur003 and ipd006 include p with no region #3

nigelmegitt opened this issue Nov 17, 2023 · 1 comment · Fixed by #5 or #6
Assignees
@palemieux
Labels
agenda For discussion on the agenda of a meeting

Comments

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Nov 17, 2023 •
edited
Loading

imsc-hrm-tests/fail/dur003-fail.ttml

Lines 14 to 16 in 2393bae

<body>
<div>
<p begin="2.5s" end="3s">z</p>

imsc-hrm-tests/fail/ipd006-fail.ttml

Lines 14 to 16 in 2393bae

<body>
<div>
<p begin="0s" end="1s">a</p>

imsc-hrm-tests/pass/dur003-pass.ttml

Lines 14 to 16 in 2393bae

<body>
<div>
<p begin="2.5s" end="3s">z</p>

imsc-hrm-tests/pass/ipd006-pass.ttml

Lines 14 to 16 in 2393bae

<body>
<div>
<p begin="0s" end="1s">a</p>

In all cases the document defines a region, so there is no default region, but there is a <p> that is not associated with any region. It's not clear why it is present and what effect it is intended to have in the IMSC-HRM algorithm.

Suggest deleting this <p> or associating it with a region, or if it's intended to have an effect, adding an XML comment explaining its unusual presence.

Is it there to produce an empty ISD, perhaps?
@nigelmegitt nigelmegitt changed the title dur003 includes p with no region fail/dur003 and fail/ipd006 include p with no region Nov 17, 2023
@nigelmegitt nigelmegitt changed the title fail/dur003 and fail/ipd006 include p with no region in pass and fail, dur003 and ipd006 include p with no region Nov 17, 2023
@nigelmegitt nigelmegitt added the agenda For discussion on the agenda of a meeting label Nov 21, 2023
@palemieux palemieux mentioned this issue Nov 23, 2023
Merged
@palemieux
Copy link
Contributor

As far as I can tell these elements were either copy-paste mistakes.

@palemieux palemieux self-assigned this Nov 23, 2023
@nigelmegitt nigelmegitt mentioned this issue Nov 23, 2023
Merged
palemieux added a commit that referenced this issue Nov 23, 2023
@palemieux
Remove unused elements
6d8593e 
#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
agenda For discussion on the agenda of a meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused elements w3c/imsc-hrm-tests
Make tests EBU-TT-D compatible w3c/imsc-hrm-tests
2 participants
@palemieux @nigelmegitt