-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed roles for nav element does not include none or presentation roles #344
Comments
Why are we restricting it at all, isn't its purpose to allow semantics to be removed regardless? This seems as absurd as saying oh, you can not use |
@jongund i think you raise a good point. Being before my time here, I can assume as to why this rule was created. Likely due to the pretty straight forward meaning of nav vs the ambiguous nature of aside to developers and how its use in html vs its aria landmark usage can seem contradictory, as I know you are already aware. I.e., aside is more ripe to unwanted semantics than nav, regardless of misuse. That said, there is no reason this couldn’t use another review and update in the next version of the spec, as I tend to agree consistency here is important. @dylanb there are definitely instances of where declaring role presentation/none would not be appropriate (as would declaring aria-hidden on certain elements, for that matter). For instance using it on a focusable element. And while I’m sure you know, this would then result in UAs having to error correct for author misuse. This of course, while not applicable for this particular issue that Jon raised, is not absurd to have restrictions if considering such situations. |
I think the disconnect here is that @jongund is talking about using ARIA to make bad code better and @scottaohara is looking at this from the perspective of "good coding practices". It is definitely better not to put role of |
This comment was marked as off-topic.
This comment was marked as off-topic.
I suggest that should not be better than should if we are going to change from must not. The spec should encourage best practice wherever practical |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I think the |
I am curious to the reasoning of allowing
none
andpresentation
roles on theaside
element, but not allowing them on thenav
element. There is a lot of abuse of thenav
element and this restriction takes away one technique to remediate those pages. It also appears to me to be a little inconsistent when another similar element,aside
is allowed to have rolenone
orpresentation
.I think
nav
should be allowed the rolesnone
orpresentation
, especially when you have nestednav
elements.The text was updated successfully, but these errors were encountered: