Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mappings for contenteditable #463

Merged
merged 5 commits into from
May 19, 2023
Merged

Clarify mappings for contenteditable #463

merged 5 commits into from
May 19, 2023

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 8, 2023

Per discussion around the minimum role concept, and the WG deciding that contentedtiable should remain unmapped to any specific ARIA role when used on a generic. per that decision #324 is closed, but the other clarifications that were to be a part of that PR are now in this one.

Additionally, there are other necessary updates needed for these mappings, as the previous ones did not get into the nuance of how to handle nested contenteditable attributes.

This PR does not include changes for contenteditable=plaintext-only (though there is some commented out text which does mention this state). Mappings for plaintext-only will be included in, or be a follow-on to #454.

plaintext-only landed in HTML - whatwg/html#8275


Preview | Diff

Per discussion around the minimum role concept, and the WG deciding that contentedtiable should remain unmapped to any specific ARIA role when used on a generic.    per that decision #324 is closed, but the other clarifications that were to be a part of that PR are now in this one.

Additionally, there are other necessary updates needed for these mappings, as the previous ones did not get into the nuance of how to handle nested `contenteditable` attributes.
@cookiecrook cookiecrook self-requested a review March 9, 2023 18:45
@jnurthen jnurthen requested review from aleventhal, jcsteh and cookiecrook and removed request for cookiecrook March 9, 2023 18:46
Copy link

@jcsteh jcsteh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me in general.

index.html Show resolved Hide resolved
@cookiecrook
Copy link
Collaborator

My review was requested in an ARIA meeting, but since the substantive changes are all related to Windows and Linux API, I'm removing myself as a reviewer.

@cookiecrook cookiecrook removed their request for review March 22, 2023 21:38
@scottaohara scottaohara merged commit 105b6fc into gh-pages May 19, 2023
@scottaohara scottaohara deleted the contenteditable branch May 19, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants