-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to contenteditable and tabindex #324
Conversation
remap ‘no corresponding role’ elements (e.g., role=generic) to role=group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @scottaohara !
Just a few notes, below, plus a question: Is it clear what "text accessible object" means?
Co-authored-by: Carolyn MacLeod <[email protected]>
Operating under the assumption that this is going to land, I'm working on making the change in Chromium. (This is independent of the name prohibition code changes btw.) Running Chromium's tests to see what broke led to me finding another thing we need to handle somewhere: The Thoughts? |
in the context of contenteditable, if not specifically named by an author, it exposing no name makes sense to me. since large areas of content can have a contenteditable parent, we would not want all that content contributing to the parent's accessible name. Similar with tabindex=0 on a scrollable div of content. what are some of the things you are finding that lost names that I might not be considering here, that we might want to maintain? |
One test that broke had this:
If a user tabs to that focusable div, they should get a name presented to them, right? |
@joanmarie yeh that's a reduced example of these https://codepen.io/scottohara/pen/bGBaYEQ where i think it'd be quite problematic for all that content to be exposed as the name. I don't think |
IMO this is something that should fit into the "handling author errors" of the ARIA spec. So if something gets focus and has no accessible name then author agents MAY correct by doing (a) (b) (c) etc. |
@scottaohara and @jnurthen I'm away on "vacation" next week. But it would be great to have consensus on this so that we can proceed doing/getting our 1.2 implementations. 😄 |
I think role=group may be too simple of a repair. |
@aleventhal have you reviewed the discussion on this in #259? |
Per discussion around the minimum role concept, and the WG deciding that contentedtiable should remain unmapped to any specific ARIA role when used on a generic. per that decision #324 is closed, but the other clarifications that were to be a part of that PR are now in this one. Additionally, there are other necessary updates needed for these mappings, as the previous ones did not get into the nuance of how to handle nested `contenteditable` attributes.
remap ‘no corresponding role’ elements (i.e.,
role=generic
or inline generic-ish elements) torole=group
if they havecontenteditable
ortabindex
set.related to #259
Review links (because unfortunately the pr-preview Preview and Diff links below are useless):
https://raw.githack.com/w3c/html-aam/contenteditable-tabindex-updates/index.html#att-contenteditable
https://raw.githack.com/w3c/html-aam/contenteditable-tabindex-updates/index.html#att-tabindex
Preview | Diff