Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool not picking up closed WG repo issues #9

Open
samuelweiler opened this issue Apr 30, 2020 · 11 comments
Open

Tool not picking up closed WG repo issues #9

samuelweiler opened this issue Apr 30, 2020 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@samuelweiler
Copy link
Member

I added -needs-resolution to WebAudio/web-audio-api#1457 after it was closed. the -tracker label didn't go away, and the needs-resolution did not propagate back to the tracker repo.

@plehegar plehegar added the bug Something isn't working label May 7, 2020
@plehegar plehegar self-assigned this May 7, 2020
@samuelweiler
Copy link
Member Author

FWIW, I just had another WG close new issues before they were labeled. (Since reviewers often can't label issues themselves, they are often relabeled by Team or review team chairs several days after they are first filed.). Example: w3c/webauthn#1517

@plehegar
Copy link
Member

plehegar commented Dec 8, 2020

it took 19 days for the working group to close w3c/webauthn#1517 . It seems to me that this should give enough time to the Team/review team to add the label... The alternative is to develop a dedicated add-on to handle those cases.

@samuelweiler
Copy link
Member Author

samuelweiler commented Dec 8, 2020

@plehegar Look again. I see w3c/webauthn#1517 as opened on 14 Nov and closed on 18 Nov.

Some of this is forward-looking - some WG's are going to be aggressive at closing issues. Good for them. I still want the tool to track the issues, and I don't want the WGs to be able to dodge the tracking with quick closing.

@plehegar
Copy link
Member

plehegar commented Dec 9, 2020

thinking more on this: I guess I can go through the closed issues. Only the recent ones however to avoid opening a bunch from the past 15 years....

@plehegar
Copy link
Member

plehegar commented Dec 9, 2020

Well, this was easier to fix than expected. It seems we didn't have any closed issues in that state. So, I unleashed the code and is now crawling through ~80k issues, open or closed.

@plehegar plehegar closed this as completed Dec 9, 2020
@plehegar
Copy link
Member

plehegar commented Jun 3, 2021

Reopening to investigate w3c/epub-specs#1648 (reported by @xfq )

@plehegar plehegar reopened this Jun 3, 2021
@samuelweiler
Copy link
Member Author

w3c/epub-specs#1648 is a PR, not an issue. Does that make any difference?

@samuelweiler
Copy link
Member Author

whatwg/html#6933 has been flagged for >12 hours and not picked up. Are we still having the "closed issues" issue?

@plehegar
Copy link
Member

plehegar commented Aug 6, 2021

@samuelweiler , it appears that my patch done in December 2020 was insufficient. :(

The good news: the tool only detected 3 issues closed in 2021 that were not properly tracked. Those have now been created properly. Future closed issues will be properly created. Note that the label "close?" will not be added at creation time but the tool will add the label at its next iteration (which happened rapidly for those 3 issues since I ran the tool a few times for deployment purposes).

The bad news: we have 375 closed issues that were not added to the horizontal repositories because those were created prior to 2021, eg w3c/webauthn#1337 (this one was "adopted" from 2019 when I updated the labels in the repositories to start using *-tracker, thus it predates the tracking). I could create a report to let us dive in those issues so that we can attempt to figure out the proper actions. wdyt?

@samuelweiler
Copy link
Member Author

Thank you!

The bad news: we have 375 closed issues that were not added to the horizontal repositories because those were created prior to 2021, eg w3c/webauthn#1337 (this one was "adopted" from 2019 when I updated the labels in the repositories to start using *-tracker, thus it predates the tracking). I could create a report to let us dive in those issues so that we can attempt to figure out the proper actions. wdyt?

I think we have enough backlog triaging older -tracker labels (when all we had was "Privacy") that should (perhaps) be upgraded to -needs-resolution, and we should handle those first. @pes10k @sandandsnow, do you agree, or would such a report be helpful now?

@plehegar
Copy link
Member

plehegar commented Aug 9, 2021

To be clear: the 375 issues are across all horizontal repos, not just privacy. the report would give us more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants