-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize the case of boolean attributes values #941
Comments
Are you using the alpha 4.2 release or 4.1.0? If 4.1.0, note that the attributes won't be available until EPUB 3.2 support is integrated. I'm not able to reproduce this in the alpha, though, as both |
I could reproduce on the I'll double-check and add either a parse-time check or fix the schemas where needed. Good catch @francofaa! |
Isn't that because it has to be |
Oh no wait, I replied too fast. Actually the issue is that the attribute name is lower-case, it should be |
In any case, boolean attributes accept values that are case-insensitive matches for their canonical name, so we should perform some case normalization at parsing time. |
- add an `HTMUtils` facility to get whether an HTML attribute has a case-insensitive value (boolean and enumerated attributes) - pre-process case-insensitive HTML attributes to lower-case their value - refactor the pre-processing attribute logic for more clarity - add a test Fix #941
- add an `HTMUtils` facility to get whether an HTML attribute has a case-insensitive value (boolean and enumerated attributes) - pre-process case-insensitive HTML attributes to lower-case their value - refactor the pre-processing attribute logic for more clarity - add a test Fix #941
epubcheck flags an error for the following attributes on element iframe:
Error reads as follows:
("..." omits the enumerated allowed attributes on iframe).
Markup from file here for testing:
HTML validator allows these, so I propose that this may be a bug in epubcheck.
The text was updated successfully, but these errors were encountered: