Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider ignoring prefix redeclarations to reserved URI #585

Closed
mattgarrish opened this issue Sep 9, 2015 · 15 comments · Fixed by #632
Closed

Consider ignoring prefix redeclarations to reserved URI #585

mattgarrish opened this issue Sep 9, 2015 · 15 comments · Fixed by #632
Milestone
4.0.1

Comments

@mattgarrish
Copy link
Member

Seems like it could become a nuisance warning, especially for rendition: which seems to be generated automatically by some software.
@rdeltour
Copy link
Member

rdeltour commented Sep 9, 2015

Right. It seems it's not even a SHOULD in the spec (which only says that it SHOULD NOT be overridden).

@rdeltour rdeltour added this to the Next milestone Sep 9, 2015
@rdeltour rdeltour self-assigned this Sep 9, 2015
@mattgarrish
Copy link
Member Author

Yes, it all kind of hinges on the interpretation of overridden, and I agree that simply redeclaring as reserved really doesn't constitute an override.

@rdeltour rdeltour mentioned this issue Sep 9, 2015
Closed
@mattgarrish mattgarrish mentioned this issue Sep 25, 2015
Closed
@eBookNoir
Copy link

@rdeltour mentioned using vanilla epubcheck, which i am guessing means from github the 4.0 version not from pagina. that worked to validate epub via another script i used, but you also have to remove <meta property="ibooks:specified-fonts">true</meta> or it won't validate with vanilla check either.

UPDATE: removing the rendition validates, but then makes the epub a reflowable on ibooks for mac, ios, google play, ADE 4 and others, meaning it adds menu for font size, etc, rendition also causes failure on vanilla epubcheck, meaning i need to zip with another script and skip validation as it seems validation is actually broken. I know this is the only error, so I'm fine skipping validation until epubcheck fixes the rendition issue and allows it in. Supposedly all you need is: pre-paginated to make fxl work, that's not the case apparently as it is failing everywhere I test.

@tofi86
Copy link
Collaborator

tofi86 commented Sep 27, 2015

I don't know what you mean with 'vanilla epubcheck'...

There should be no difference between the 4.0.0 release from github and the pagina EPUB-Checker 1.5 as it uses the exact 4.0.0 library internally...

@eBookNoir
Copy link

That was the wording i was given, I figured it must have meant just epubcheck via terminal and the java app. Either way the rendition warning is failing files, it shouldn't be. If removed, they then act as reflowable, so something somewhere is wrong.

@tofi86
Copy link
Collaborator

tofi86 commented Sep 27, 2015

Alright, so the result from our Twitter discussion is, that pagina EPUB-Checker and Epubcheck are behaving the same. Good to know. Still, there's something wrong with the renditions property which should be further investigated in this thread...

@eBookNoir
Copy link

Agree, that something must be off if the file turns reflowable in apps because of rendition prefix removed. and specified-fonts has to be removed.

@mattgarrish
Copy link
Member Author

It could well happen that the property gets ignored if the reading system resolves the CURIE to a full URI for comparison. If the rs doesn't recognize "rendition:" as automatically mapping to the stem "http://www.idpf.org/vocab/rendition/#" then it won't see the publication as having FXL properties.

Reserving the prefix to simplify authoring was the intention of the FXL group, and none of the rs vendors spoke up during the 3.0.1 revision that it was problematic for them, so odd (but not unexpected) that there would be a failure without an explicit declaration.

But this is why epubcheck shouldn't emit anything for a simple redeclaration.

@rdeltour rdeltour modified the milestones: 4.0.1, Next Sep 29, 2015
@wattoo
Copy link

wattoo commented Oct 5, 2015

I'm sorry but I don't understand what I have to do.
I must send an epub 3 FXL on the ibooks store. And I have this problem with epubcheck.
So what can I do ?
If I delete "prefix="rendition: http://www.idpf.org/vocab/rendition/#"" my epub becomes reflowable on iPad.
And I'm afraid if I don't delete it, iTunes Producer will not accept my epub 3 FXL....

@jstallent
Copy link

Apple's Transporter validator will accept the file even though it has the
rendition redeclaration. Also, the other retailers have not, as far as I
know, updated to 4.0 yet, so you should not have problems with them, either.

JOSHUA TALLENT | Director of Outreach and Education
[email protected]
978-225-2757
www.firebrandtech.com
www.ebookarchitects.com

@jtallent
@eBookArchitects
@askburnie

Pre-flight your EPUB files with FlightDeck. Validation, Retailer Acceptance
Grid, Metadata Editing, and more!
http://eBookFlightDeck.com http://ebookflightdeck.com/

On Mon, Oct 5, 2015 at 7:52 AM, wattoo [email protected] wrote:

I'm sorry but I don't understand what I have to do.
I must send an epub 3 FXL on the ibooks store. And I have this problem
with epubcheck.
So what can I do ?
If I delete "prefix="rendition: http://www.idpf.org/vocab/rendition/#""
my epub becomes reflowable on iPad.
And I'm afraid if I don't delete it, iTunes Producer will not accept my
epub 3 FXL....

—
Reply to this email directly or view it on GitHub
#585 (comment).

@wattoo
Copy link

wattoo commented Oct 5, 2015

Thank you very very much !!!

Le 5 oct. 2015 à 17:00, Joshua Tallent [email protected] a écrit :

Apple's Transporter validator will accept the file even though it has the
rendition redeclaration. Also, the other retailers have not, as far as I
know, updated to 4.0 yet, so you should not have problems with them, either.

JOSHUA TALLENT | Director of Outreach and Education
[email protected]
978-225-2757
www.firebrandtech.com
www.ebookarchitects.com

@jtallent
@eBookArchitects
@askburnie

Pre-flight your EPUB files with FlightDeck. Validation, Retailer Acceptance
Grid, Metadata Editing, and more!
http://eBookFlightDeck.com http://ebookflightdeck.com/

On Mon, Oct 5, 2015 at 7:52 AM, wattoo [email protected] wrote:

I'm sorry but I don't understand what I have to do.
I must send an epub 3 FXL on the ibooks store. And I have this problem
with epubcheck.
So what can I do ?
If I delete "prefix="rendition: http://www.idpf.org/vocab/rendition/#""
my epub becomes reflowable on iPad.
And I'm afraid if I don't delete it, iTunes Producer will not accept my
epub 3 FXL....

—
Reply to this email directly or view it on GitHub
#585 (comment).

—
Reply to this email directly or view it on GitHub.

@ferformaat
Copy link

@jstallent And what do we do when they will use the epubcheck version 4.0?
Could this be a 'wrong warning' in the checker - a fault in this version?

@jstallent
Copy link

@ferformaat my understanding based on what @mattgarrish says above is that this warning should not be happening in EPUBCheck 4.0, and that it should be fixed in the next update.

@rdeltour
Copy link
Member

@ferformaat what @jstallent said above is correct, this will be fixed in v4.0.1, which will be released very soon.

@ferformaat
Copy link

Thanks a lot. Now I know I can't stop the investigation.

rdeltour added a commit that referenced this issue Oct 21, 2015
@rdeltour
Ignore explicit declarations of reserved prefixes
ebc1c75 
- added a new method to `Vocab` to get the base URI of a vocabulary
- In the prefix parsing utility of `VocabUtil`, check the URI associated
  with re-declared reserved prefix: an error is reported only if this
  URI is **not** the URI of the known vocabulary associated to the
  reserved prefix. In other words, explicit declaration of reserved
  prefixes is now allowed; trying to override a reserved prefix still
  raises an error.

Fixes #585
@rdeltour rdeltour mentioned this issue Oct 21, 2015
Merged
@rdeltour rdeltour mentioned this issue Nov 29, 2015
Closed
@toshiakikoike toshiakikoike mentioned this issue Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging a pull request may close this issue.

Ignore explicit declarations of reserved prefixes w3c/epubcheck
7 participants
@tofi86 @rdeltour @mattgarrish @eBookNoir @jstallent @ferformaat @wattoo