Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing semicolon in .css ignored #243

Closed
rdeltour opened this issue Oct 15, 2013 · 4 comments
Closed

Missing semicolon in .css ignored #243

rdeltour opened this issue Oct 15, 2013 · 4 comments
Labels
type: duplicate The issue duplicates an existing issue

Comments

@rdeltour
Copy link
Member

From [email protected] on January 24, 2013 12:52:13

PROBLEM: I forgot to terminate a rule in my stylesheet.css with a semicolon, which caused a lot of rendering issues on the Nook. Epubcheck did not catch the missing semicolon, which would have been nice.

METHOD: Something like this:

table {
  width: 100%
  height: 100%;
}

RESULT: No warning issued. Rendering a mess.

EXPECTED: Warning about missing semicolon.

PLATFORM: Epubcheck 3.0 on Mac 10.6.8

java version "1.6.0_37"
Java(TM) SE Runtime Environment (build 1.6.0_37-b06-434-10M3909)
Java HotSpot(TM) Client VM (build 20.12-b01-434, mixed mode)

ADDITIONAL INFO: n/a

Original issue: http://code.google.com/p/epubcheck/issues/detail?id=243

@rdeltour
Copy link
Member Author

From [email protected] on March 26, 2013 05:32:30

Status: Accepted
Labels: Type-Enhancement

@madevelopers
Copy link

I also encountered an issue with ADE not applying my css rules when the stylesheet has syntactic errors. I have captured the errors using w3c validator. It would be helpful if this gets integrated or the same feature be added to epubcheck.

@tofi86 tofi86 added type: bug The issue describes a bug css validation and removed type: improvement The issue suggests an improvement of an existing feature labels Jun 5, 2017
@tofi86
Copy link
Collaborator

tofi86 commented Jul 4, 2017

Confirmed. Still happens with 4.0.2 and current dev version. The following CSS snippet does not throw an error:

table {
  width: 100%
  height: 100%;
}

result:

Validating using EPUB version 3.0.1 rules.
No errors or warnings detected.
epubcheck completed

@rdeltour
Copy link
Member Author

I'm not sure that missing semicolons are strictly a syntax error, as in this case it makes the line par of the previous declaration.

In any case, closing this as duplicate of the meta-issue #981

@rdeltour rdeltour added type: not an issue The issue is rejected (not an actual issue or not relevant) type: duplicate The issue duplicates an existing issue and removed type: bug The issue describes a bug type: not an issue The issue is rejected (not an actual issue or not relevant) labels Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: duplicate The issue duplicates an existing issue
Projects
None yet
Development

No branches or pull requests

4 participants