-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epub:type="noteref" on <a> inside svg #1497
Comments
It does look like a false positive. Thanks for the report! |
I had a closer look about this. Not sure how to interpret the spec:
That said, strictly speaking, the last point above only references 6.2.3 "Restrictions on SVG", and the So this raises the following questions:
@mattgarrish @iherman any thoughts? (edited to use dated spec refs) |
Ya, they do. The only difference between the two is that one is a standalone file and the other is a document fragment. I'm sure we can solve the referencing issue with a bit of work. We can't just reference the section that allows epub:type, though, because it also defines that svg content documents must be standalone files.
No, as I recall, the restrictions were added to try and match the HTML restriction that epub:type isn't allowed on metadata elements. The attribute should still be allowed on (More relevant to when we fix the EPUB spec, but for some reason these category references in the 3.3 spec go to the SVG 1.1 definitions; the rest of the SVG references use "TR/SVG/" urls. We should look at fixing them.) |
yeah, the simplest might be to move the
👍 |
To be honest, I do not remember any more, so I would have to look at all this more closely, and I am not sure I can do that before Monday or maybe even Tuesday. However... with my W3C staff contact's hat on: the spec is now in Proposed Rec, ie, under the vote of the AC. In theory, provided that the AC will vote positively, the only changes that we will be allowed to do when moving the document to a Rec are cosmetic ones: spelling mistakes, essentially (plus the adaptation of the document header and the status section). This means that this thing should be submitted as a possible Erratum to the spec, with a Summary as for the proposed handling of it, and once the maintenance WG has been set up, that WG may decide to make a republication following the process. I am sorry to be awfully administrative with al this, but that is the way it is, and we will have to follow the rules... |
sure, but in any case we can incubate any erratum to the PR spec in EPUBCheck (as long as we figure out what to do here). |
Ya, I wasn't considering the actual fixing of the spec at this point. What we need to figure out is what the restriction should be for svg. Looking at the SVG2 spec, is there any reason why we couldn't have just said the epub:type attribute must be used on renderable elements? That definition includes |
Yes, I figured the same (but I'm no SVG expert). |
Oh, scratch that, maybe the elements listed in the paragraph is all I need. The "it includes" made me think there could be others not explicitly listed there, but maybe not. |
Ya, I don't think so, beyond maybe extension elements -- but as far as I can tell those aren't rendered by default and I don't think epubcheck verifies them anyway. Looking at various element definitions, they all appear to be categorized as renderable or never-rendered content. |
Thank you very much, @rdeltour @mattgarrish! |
With something like the following
epubcheck 5 gives me the following error:
ERROR(RSC-005): svg_a_noteref.epub/OEBPS/Text/Section0001.xhtml(15,54): Error while parsing file: attribute "epub:type" not allowed here
Is this a false positive by any chance?
Here's also a minimal example epub (renamed to .zip)
The text was updated successfully, but these errors were encountered: