Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match epub:type checking in overlays documents to content documents #1171

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

mattgarrish
Copy link
Member

Processing of epub:type is supposed to be constrained identically to content documents, which means as of 3.2 unknown values without a prefix are usage messages.

This updates the processing to match what is in place for content documents by aggregating unchecked_vocab and then iterating the value(s) after to issue usage message(s).

…usage message for unknown values from structure vocab)
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test can be improved to check the usage (see comment), but otherwise LGTM! 👍

@rdeltour rdeltour merged commit f8a2517 into master Sep 1, 2020
@rdeltour rdeltour deleted the fix/overlays-epub-type branch September 1, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants