Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscores in the host part of URLs #1079

Closed
Mustaf2659 opened this issue Sep 13, 2019 · 8 comments · Fixed by #1131
Closed

Allow underscores in the host part of URLs #1079

Mustaf2659 opened this issue Sep 13, 2019 · 8 comments · Fixed by #1131
Assignees
Labels
priority: low To be processed when time allows status: has PR The issue is being processed in a pull request type: improvement The issue suggests an improvement of an existing feature
Milestone

Comments

@Mustaf2659
Copy link

While validate the ePub File the below URL showing error as "missing 1 slash(es) '/' after the protocol 'http:'", but the url link works fine.

<a href="http://encyclopedie_universelle.fracademic.com/65285"> http://encyclopedie_universelle.fracademic.com/65285 </a>

Please suggest how solve this issue.

@rdeltour
Copy link
Member

At first sight this looks like the same issue as #1034, but I’m not 100% sure sine the URL you’re showing here looks right.

Would you be able to share a full EPUB file to help us reproduce the error?

@rdeltour rdeltour self-assigned this Sep 13, 2019
@rdeltour rdeltour added the status: waiting for feedback The development team needs feedback from the issue’s creator label Sep 13, 2019
@Mustaf2659
Copy link
Author

Unable to share full ePub file, herewith attached Sample ePub Package with the URL link causing error in Checker

Sample.zip

@rdeltour
Copy link
Member

thanks @Mustaf2659!

@rdeltour
Copy link
Member

Ah, the issue comes from the use of the underscore character ('_') in the host name, which is disallowed.
Now, as most browsers will be able to reach the link, I'm wondering if EPUBCheck should be more permissive here.

@rdeltour rdeltour added status: in discussion The issue is being discussed by the development team and removed status: waiting for feedback The development team needs feedback from the issue’s creator labels Sep 13, 2019
@Mustaf2659
Copy link
Author

Thanks @rdeltour for your information.

@rdeltour rdeltour added type: duplicate The issue duplicates an existing issue and removed status: in discussion The issue is being discussed by the development team labels Sep 13, 2019
@rdeltour
Copy link
Member

All things considered, I still think there is an issue here. EPUBCheck should not reject this URL, as the hyperlink works in most browsers.

I’m reopening the issue and changing its title for easier reference.

@rdeltour rdeltour reopened this Sep 13, 2019
@rdeltour rdeltour added priority: low To be processed when time allows status: in discussion The issue is being discussed by the development team type: improvement The issue suggests an improvement of an existing feature and removed type: duplicate The issue duplicates an existing issue labels Sep 13, 2019
@rdeltour rdeltour changed the title Error in ePub Checker 4.2.2 Allow underscore in the host part of URLs Sep 13, 2019
@rdeltour rdeltour changed the title Allow underscore in the host part of URLs Allow underscores in the host part of URLs Sep 13, 2019
@mattgarrish
Copy link
Member

Ya, isn't the issue that you can't register domain names with underscores but you can create subdomains with them as the rules aren't often enforced?

It really shouldn't result in warnings, as there's no encoding fix to get around it that I know of and the author likely can't change the URL.

@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: in discussion The issue is being discussed by the development team labels Apr 27, 2020
@rdeltour rdeltour added this to the 4.2.3 milestone Apr 27, 2020
@Mustaf2659
Copy link
Author

Hi @rdeltour and @mattgarrish,

Thanks for fixes in ePub checker 4.2.3, issue resolved.

Regards,
Mustafa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low To be processed when time allows status: has PR The issue is being processed in a pull request type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants