-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depreciated epub:types should generate USAGE not ERROR #1009
Comments
Thanks @nekennedy for the feedback! 👍
In the latest editor's draft of the Structural Semantics Vocabulary (that will be published in sync with EPUB 3.2), the
Yes, this is now conforming to EPUB 3.2, which says:
I see where you're coming from, when looking at the See also the discussion in #531 and w3c/epub-specs#1222. If you think this behavior should be reconsidered it would need to be discussed in the CG, for instance by commenting on w3c/epub-specs#1222. For now, EPUBCheck's behavior seems to be conforming to the spec (forthcoming 3.2 vocab), so I'm closing the issue as |
The general consensus on the call today is that invalid use of epub:type doesn't warrant warning/errors. It serves no particular function beyond pop-up footnotes, so there's no value in forcing people to fix any misuses. I misunderstood the issue a bit, as I thought this was about the terms we had marked recently as deprecated, not about the terms that are only intended for media overlays, but my impression is that the group wants them all treated the same way as usage messages. |
Ah, sorry I wasn't on the call… So everything What happen to generic errors like an undeclared prefix or invalid prefix declaration, they would still be reported as errors, correct? |
I don't think we need to go that deep into changing severity, no. If you're using those mechanisms, then you'll likely want the messages. This issue generally focuses around not causing validation problems for the unprefixed terms in epub:type. Correct @dauwhe @RachelComerford @TzviyaSiegman ? |
would the deprecated properties other than |
Message changes: - `OPF-086` (`WARNING`) only reports deprecated properties other than `epub:type`. - `OPF-086b` new message reports deprecated `epub:type` values as `USAGE` - `OPF-087`, reporting not-allowed properties, becomes a `USAGE`. Fix #1009
Message changes: - `OPF-086` (`WARNING`) only reports deprecated properties other than `epub:type`. - `OPF-086b` new message reports deprecated `epub:type` values as `USAGE` - `OPF-087`, reporting not-allowed properties, becomes a `USAGE`. Fix #1009
Currently deprecated epub:type elements are generating an error, unknown ones are generating a usage message:
ERROR(OPF-087): ./Documents/Development/Sprints/Jeremy/4_2/9781524761547.epub/OEBPS/Acho_9781524761547_epub3_c01_r1.xhtml(12,57): Property 'list' is not allowed on documents of type 'application/xhtml+xml'.
USAGE(OPF-088): ./Documents/Development/Sprints/Jeremy/4_2/9781524761547.epub/OEBPS/Acho_9781524761547_epub3_c01_r1.xhtml(15,32): Unrecognized property 'chair'.
Proposal: either make them the same, or change the deprecated property to USAGE and "Depreciated property 'XXXXX'."
The text was updated successfully, but these errors were encountered: