Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publicKeyMultibase verification method property. #299

Merged
merged 1 commit into from
May 15, 2021
Merged

Add publicKeyMultibase verification method property. #299

merged 1 commit into from
May 15, 2021

Conversation

msporny
Copy link
Member

@msporny msporny commented May 8, 2021 •
edited by pr-preview bot
Loading

@msporny msporny requested a review from OR13 as a code owner May 8, 2021 16:07
This was referenced May 8, 2021
Closed
Merged
@peacekeeper
Copy link
Contributor

I guess this PR could also mark publicKeyHex and publicKeyBase58 as deprecated (like publicKey has been marked as deprecated in favor of verificationMethod).

@msporny
Copy link
Member Author

msporny commented May 15, 2021

I guess this PR could also mark publicKeyHex and publicKeyBase58 as deprecated (like publicKey has been marked as deprecated in favor of verificationMethod).

I was going to do that in a separate PR... I don't know where the best place to do that would be -- in the security vocab (where it's already done)... or in this registry... probably both places... need to think on it some more.

@msporny msporny merged commit c3044b7 into main May 15, 2021
@msporny msporny deleted the msporny-did-core-issue-707 branch November 14, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 approved these changes

@peacekeeper peacekeeper peacekeeper approved these changes

@dlongley dlongley dlongley approved these changes

@brentzundel brentzundel Awaiting requested review from brentzundel

@kdenhartog kdenhartog Awaiting requested review from kdenhartog

@dmitrizagidulin dmitrizagidulin Awaiting requested review from dmitrizagidulin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msporny @peacekeeper @dlongley @OR13