Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial cleanup of simple example section. #613

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Editorial cleanup of simple example section. #613

merged 3 commits into from
Feb 12, 2021

Conversation

msporny
Copy link
Member

@msporny msporny commented Feb 10, 2021 •
edited by pr-preview bot
Loading

brentzundel
brentzundel approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit. I wasn't sure what it means to "authenticate with a DID controller"

index.html Outdated Show resolved Hide resolved
@msporny msporny added the editorial Editors should update the spec then close label Feb 11, 2021
@msporny
Copy link
Member Author

msporny commented Feb 12, 2021

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit b4c85fc into main Feb 12, 2021
@msporny msporny deleted the msporny-cr-simple-example branch February 21, 2021 21:23
@peacekeeper peacekeeper mentioned this pull request Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentzundel brentzundel brentzundel approved these changes

@OR13 OR13 OR13 approved these changes

@talltree talltree Awaiting requested review from talltree

Assignees
No one assigned
Labels
editorial Editors should update the spec then close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msporny @OR13 @brentzundel