Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-pseudo-4] Define ::picker() #10865

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[css-pseudo-4] Define ::picker() #10865

merged 2 commits into from
Sep 17, 2024

Conversation

josepharhar
Copy link
Contributor

This was discussed here: #10440

This was discussed here: w3c#10440
Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly fine. A few comments below.

css-pseudo-4/Overview.bs Show resolved Hide resolved
css-pseudo-4/Overview.bs Outdated Show resolved Hide resolved

The ''::picker()'' pseudo-element only matches when the <a>originating
element</a> supports <a>base appearance</a> and has a popup picker. The
specified <<ident>> must also match the unique picker name of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be defining the term "unique picker name" (for other specs to reference), unless you think it should be defined somewhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Do you think that HTML should define the mapping?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think HTML should define it.

@josepharhar josepharhar changed the title Define ::picker() [css-pseudo-4] Define ::picker() Sep 17, 2024
@dbaron dbaron merged commit 5344c61 into w3c:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants