Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebKit mappings are not correct for style-based roles: strong, emphasis, maybe more… #126

Open
cookiecrook opened this issue Jun 30, 2022 · 3 comments
Assignees
Milestone

Comments

@cookiecrook
Copy link
Contributor

WebKit mappings are not correct for style-based roles: strong, emphasis, maybe more…

There are number of AXSubroles listed that don't match the implementation: AXStrongStyleGroup, AXEmphasisStyleGroup, etc.

Looks like @joanmarie made the change in WebKit but it was immediately reverted, due to breakage. So it was only in a single nightly build, as far as I can tell. WebKit/WebKit@8095dc1

@cookiecrook
Copy link
Contributor Author

FWIW, I'm still of the opinion that <strong> and <em> should map to generic, not new stylistic ARIA roles.

@cookiecrook
Copy link
Contributor Author

<code> and some others seem reasonable to have a role. See discussion in w3c/html-aam#373

@cookiecrook cookiecrook added this to the 1.3 milestone Jul 1, 2022
@cookiecrook cookiecrook self-assigned this Jul 1, 2022
@cookiecrook
Copy link
Contributor Author

cookiecrook commented Jul 1, 2022

Regardless of whether we keep or ditch the strong role, I think the mapping for <strong> and <b> would still be:

AXRole: AXGroup
AXRole: <nil>
Expose the text style as Bold.

Ditto for the new emphasis style role:

AXRole: AXGroup
AXRole: <nil>
Expose the text style as Italic.

Which WebKit already does, so this fix can probably proceed regardless of the other discussion about generic roles. I'll wait a while for @joanmarie or others to comment before posting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant