Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address alignment #198

Closed
wants to merge 7 commits into from
Closed

Conversation

adamroach
Copy link
Contributor

Proposal for issue #189

@rvm4
Copy link
Collaborator

rvm4 commented May 17, 2016

LGTM. I think the names are largely immaterial, but I do prefer the proposed names as I think they are more commonly used. I suggest we merge this an PR 197.

@jnormore
Copy link
Member

👍 makes sense

@adrianba
Copy link
Contributor

Merged as 55dfb49 per telcon.
Fixes #189.

@adrianba adrianba closed this May 19, 2016
@adrianba adrianba mentioned this pull request May 19, 2016
@adamroach adamroach deleted the address-alignment branch May 20, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants