-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider revising the design of complete() #122
Comments
complete() was addressed in PR #161 but this specific issue was not dealt with. A proposal is required to address this and other comments made in the PR |
The existing design calls for three possible values here (success, failure and a third state representing "unknown"). That doesn't map well into the binary success/failure model that Promises provide, and the point of PR #163 was to expand from two choices into three. While I agree that Promise would be a better choice if we could guarantee that the web page knows the success status, moving in this direction seems to reintroduce an already-solved problem. Perhaps we could include information in the resolution case to distinguish between "success" and "unknown"? It seems somewhat inelegant, but better than what we have now. |
We could resolve a promise with a status ( |
In TAG review @triblondon said:
The text was updated successfully, but these errors were encountered: