Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Bump Stylelint v16 and use MJS config file #3082

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

nschonni
Copy link
Contributor

Alternate to #2853
@howard-e I bumped the packages, but ignored the new failing rules in this one, to see if that makes it easier to land (and fix separately). I also converted the config file so comments could be added for why rules might be disabled.

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni thanks! This is great and a plus over #2853

'selector-class-pattern': null,
'selector-id-pattern': null,
// Fixable Stylelint 16 rules
'declaration-block-no-redundant-longhand-properties': null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking further on this, it is better to ignore instead of what I was doing in #2853, as using top right bottom left is still so popularly used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants