Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmark AT Example page using percentage based image widths #427

Closed
nschonni opened this issue Jul 20, 2017 · 3 comments
Closed

Landmark AT Example page using percentage based image widths #427

nschonni opened this issue Jul 20, 2017 · 3 comments
Assignees
@jnurthen
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Milestone
1.1 APG Release 1

Comments

@nschonni
Copy link
Contributor

Found this running the Nu validator https://travis-ci.org/w3c/aria-practices/builds/253487231#L418
Looks like those widths need to be in pixels in HTML5 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Img#attr-width
@nschonni nschonni mentioned this issue Jul 20, 2017
Merged
@jnurthen jnurthen self-assigned this Jul 20, 2017
@jnurthen jnurthen mentioned this issue Jul 20, 2017
Closed
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Jul 20, 2017

Fixed in e3547be

@ZoeBijl ZoeBijl closed this as completed Jul 20, 2017
@nschonni
Copy link
Contributor Author

Technically the PR hasn't landed, but the changes look 💯

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Jul 21, 2017

Discussed the change I made yesterday with @jnurthen and he approves.

@mcking65 mcking65 added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Jul 27, 2017
@mcking65 mcking65 added this to the 3Q17 Working Draft milestone Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
Landmark Regions Guidance and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
4 participants
@nschonni @jnurthen @ZoeBijl @mcking65