Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text and Page contents section a11y issues #2606

Closed
jnurthen opened this issue Feb 10, 2023 · 5 comments
Closed

Text and Page contents section a11y issues #2606

jnurthen opened this issue Feb 10, 2023 · 5 comments
Labels
bug Code defects; not for inaccurate prose Site Design Related to design of the APG site on w3.org built during 2021 redesign project

Comments

@jnurthen
Copy link
Member

filed in response to https://lists.w3.org/Archives/Public/public-aria-practices/2023Feb/0003.html

text copied here for reference:

Two core issues I ran into are:

  1. Headings (particularly the Patterns) bleed past the container (https://www.w3.org/WAI/ARIA/apg/patterns/) - breadcrumbs, disclosure
  2. When in a particular pattern, the Page contents section blocks nearly the entire page. (https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/)

I am legally blind and use magnification and text magnification. The following are the specs of my environment:
OS: Mac OSx Monterey 12.6.3

Browser: Chrome 109.0.5414.119
Within Chrome Preferences:
Appearance ~ Font Size: Very Large
Appearance ~ Page Zoom:110%

Browser: Safari Version 16.3
Within Safari Preferences:
Advanced ~ New use font sizes smaller than: 18
Page Zoomed: 110%

@jnurthen
Copy link
Member Author

Screenshot showing issue (1)

Screenshot 2023-02-10 at 10 40 55 AM

Video showing the Page Contents section becoming large at certain breakpoints (2)

Screen.Recording.2023-02-10.at.10.44.43.AM.mov

@a11ydoer
Copy link
Contributor

Thanks for transferring the issue to github, @jnurthen
@alflennik @howard-e, Can you kindly look into the problems?

@howard-e
Copy link
Contributor

Thanks @jnurthen @a11ydoer. Seems #2601 is also related.

@jnurthen
Copy link
Member Author

jnurthen commented Feb 14, 2023

+1 on #2601
The problem is that the header becomes sticky at 960px (https://github.com/w3c/wai-aria-practices/blob/83c8575ad4e0379868df5b5c92bdc84a03f2d48f/content-assets/wai-aria-practices/styles.css#L41) but the grid takes effect at 60em which is driven by this variable https://github.com/w3c/wai-website-theme/blob/a60a7002fb117e5c9389f972b442372aa2deb065/_css/base.css#L6 . Now - these are often the same but when the user has larger font sizes they are not which is why we are seeing this.

For simplicity I would probably look at changing our breakpoint from 960px to 60em (unless there is a way in our css to use the same variable as that would probably be the best long term solution)

@a11ydoer a11ydoer assigned a11ydoer and alflennik and unassigned a11ydoer Feb 14, 2023
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Site Design Related to design of the APG site on w3.org built during 2021 redesign project labels Feb 14, 2023
@alflennik alflennik removed their assignment Mar 1, 2023
@mcking65 mcking65 added this to the H1/2023 Content Updates milestone Jul 25, 2023
@a11ydoer
Copy link
Contributor

@mcking65 This issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Site Design Related to design of the APG site on w3.org built during 2021 redesign project
Projects
None yet
Development

No branches or pull requests

5 participants