Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining examples without CodePen buttons #1790

Closed
zcorpan opened this issue Mar 1, 2021 · 3 comments
Closed

Remaining examples without CodePen buttons #1790

zcorpan opened this issue Mar 1, 2021 · 3 comments
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation

Comments

@zcorpan
Copy link
Member

zcorpan commented Mar 1, 2021

I've updated this project board to move cards associated with PRs that were merged into the "Done" column:

https://github.com/w3c/aria-practices/projects/31

I can see 2 open PRs that add CodePen buttons to more examples: #1651, #1685.

The "Feed" pattern is in the "Pages that are blocked" column, but not comment for why. Reviewing the example, the feed pattern is on a separate page instead of being included in the example page itself.

When doing a static analysis of which example pages don't contain a CodePen button (or rather, don't contain the substring example-heading), I found several that are not covered by the above-mentioned open PRs:

$ find . -name "*.html" | xargs grep -L 'example-header'

Are these intentionally omitting the CodePen buttons, or are there cards in the project board that should be moved back from "Done" to "Backlog"?

cc @jesdaigle

@zcorpan zcorpan added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Mar 1, 2021
@mcking65
Copy link
Contributor

mcking65 commented Mar 3, 2021

@zcorpan thank you for the validation of progress and update of the project board.

We are not going to do any of the /landmark example pages.

Advanced data grid is just a placeholder page; still don't have an example there.

Feed is blocked for now.

I think that leaves only editor menubar not covered by an open PR. I moved editor menubar back to the backlog column. We mistakenly had it covered by pr #1741, which was for re-write of navigation menubar.

@zcorpan
Copy link
Member Author

zcorpan commented May 10, 2021

Current status: the backlog and in progress columns are now empty. #1876 and #1651 are in review. The feed example is blocked.

What is blocking the feed example?

@mcking65
Copy link
Contributor

mcking65 commented Oct 1, 2023

Since we are not implementing codepen for landmark examples and since feed will be unblocked and resolved by #2775, closing this issue.

@mcking65 mcking65 closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

No branches or pull requests

2 participants