Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-haspopup incorrectly used for ARIA 1.2 Editable Combobox With List Autocomplete Example #1323

Closed
LaurenceRLewis opened this issue Feb 4, 2020 · 2 comments

Comments

@LaurenceRLewis
Copy link

Could someone please explain why aria-haspop is set to true when it is followed by a role listbox in the example on the page 'Editable Combobox With List Autocomplete Example'
https://www.w3.org/TR/wai-aria-practices-1.2/examples/combobox/combobox-autocomplete-list.html

<input id="cb1-input" class="cb_edit" type="text" role="combobox" aria-autocomplete="list" aria-expanded="true" aria-controls="cb1-listbox" aria-haspopup="true" aria-activedescendant="">

<ul id="cb1-listbox" role="listbox" aria-label="States" tabindex="-1" class="" style="display: block;">

A popup element usually appears as a block of content that is on top of other content. Authors MUST ensure that the role of the element that serves as the container for the popup content is menu, listbox, tree, grid, or dialog, and that the value of aria-haspopup matches the role of the popup container.

@scottaohara
Copy link
Member

@LaurenceRLewis did you mean to file this over on the APG's github, or do you think something needs to be changed in the ARIA specification?

@jnurthen jnurthen transferred this issue from w3c/aria Feb 5, 2020
@carmacleod
Copy link
Contributor

Hi, @LaurenceRLewis!

explain why aria-haspop is set to true when it is followed by a role listbox

Because the fix hasn't been merged yet. :)
(The fix deletes aria-haspopup from combobox examples that have a listbox popup).

The PR we are waiting on merging is #1276.
We wanted to test some old issues first (to make sure the PR resolves them) before merging.

@mcking65 I tested the 5 old combobox issues listed on today's agenda, and PR #1276 resolves them all (with the possible exception of a bit of editorial work in #785 that can be looked at separately). I think it can be merged now.

I'm closing this issue as a duplicate of #1261 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants