Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria.js running too late #92

Open
pkra opened this issue Apr 28, 2023 · 2 comments
Open

aria.js running too late #92

pkra opened this issue Apr 28, 2023 · 2 comments
Assignees

Comments

@pkra
Copy link
Member

pkra commented Apr 28, 2023

It seems aria.js is running too late, causing an issue with heading levels, cf. https://github.com/w3c/respec/issues/4436.

@pkra
Copy link
Member Author

pkra commented May 3, 2023

Trying to read up on things. It looks like aria.js // ariaAttributeReferences() intentionally runs after respec.

On the one hand, e.g., the ARIA spec has ariaAttributeReferences in the respecConfig's postProcess array:

https://github.com/w3c/aria/blob/60f526c0a93575a2f3194d85dfd70f1eaf2991d1/index.html#LL145C39-L145C39

If I move it to the preProcess array, we get the correct headings.

But I don't know if post-processing was intentional. git says @jnurthen might remember -- w3c/aria@613eacf.

Then there's also

aria-common/script/aria.js

Lines 797 to 800 in b3b7981

respecEvents.sub('end', function (msg) {
if (msg == 'w3c/conformance') {
ariaAttributeReferences();
}

which git blame also says @jnurthen might know - do you remember if this was intentional?

@pkra
Copy link
Member Author

pkra commented May 15, 2023

As noted in today's meeting, we should try to refactor the code and move the heading-generating code so that it can be done in pre-processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants