Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of results collection form has title and instructions that are inconsistent with preview of test plan #1010

Closed
mcking65 opened this issue Dec 4, 2023 · 2 comments
Labels
bug Something isn't working javascript Pull requests that update Javascript code

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 4, 2023

Testing for issue #977 , which is resolved by #997 , I found that the headings and test instructions are correctly presented in the test plan preview, but if you follow the link to view the preview of the results collection form, the instructions still have the V1 text and format.

For example, the 997 preview for Alert Example Test Plan | For Pattern: alert has the correct headings and instructions. However, if you open the link to the JAWS collection form for test 1, Trigger an alert, I found the following inconsistencies.

The H1 in the preview is:

Testing task: Trigger an alert

It should be:

Test: Trigger an alert

Following the H1, the following paragraph is still present. It should not be there:

With JAWS in PC cursor active mode, describe how JAWS behaves when performing task "With focus on the 'Trigger Alert' button, activate the button to trigger the alert."

The H2 shown in the preview is:

Test instructions

It should be:

Instructions

The list of instructions shown is:

  1. Restore default settings for JAWS. For help, read Configuring Screen Readers for Testing.
  2. Activate the "Open test page" button below, which opens the example to test in a new window and runs a script that sets focus on the 'Trigger Alert' button.
  3. Press Alt + Delete to determine which cursor is active. If the virtual cursor is active, press Insert + z to disable the virtual cursor.
  4. With focus on the 'Trigger Alert' button, activate the button to trigger the alert.
  5. Using the following commands, With focus on the 'Trigger Alert' button, activatethe button to trigger the alert.
    • Space (virtual cursor active)
    • Enter (virtual cursor active)
    • Space (PC cursor active)
      ◦ Enter (PC cursor active)

The instructions should exactly match the instructions section on Alert Example Test Plan | For Pattern: alert, including the instructions for settings that follow the numbered list.

Following the instructions, the success criteria section is still present. This is documented separately in #1009.

@mcking65 mcking65 added the bug Something isn't working label Dec 4, 2023
@mcking65
Copy link
Contributor Author

mcking65 commented Dec 4, 2023

The requirements for the preview are the same as the requirements for the test runner specified in w3c/aria-at-app#743. Since this preview is only used primarily by Isabel, James, and myself, it is not as critical as ensuring this content is correct in the test runner, which is used by all testers. So, I am prioritizing fixing this bug as a P2 rather than P1.

@mcking65
Copy link
Contributor Author

Looked at the tests preview linked in #1017. For example, JAWS tests for alert. That PR fixes this problem.

@ccanash ccanash moved this from In sandbox to In production / Completed in Refactor ARIA-AT test structure and test result presentation project Apr 8, 2024
@ccanash ccanash closed this as completed Apr 8, 2024
@ccanash ccanash moved this from In Progress to In production / Completed in Refactor ARIA-AT test structure and test result presentation project Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
Development

No branches or pull requests

2 participants