Update Reports for V2 Test Format #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
howard-e
force-pushed
the
v2-test-format-reports
branch
from
1f67191 to
1f797df
Compare
alflennik
reviewed
Nov 21, 2023
| return ( | ||
| <> | ||
| {isReportsPage ? <h3>Results for each command</h3> : null} |
There was a problem hiding this comment.
If this headline is not always needed maybe it's a sign it doesn't belong in this component and can be handled by the parent component.
There was a problem hiding this comment.
Good point, addressed in 9eb5875.
| {passedAssertions.length} passed, | ||
| {failedAssertions.length} failed | ||
| </h3> | ||
| {isReportsPage ? ( |
There was a problem hiding this comment.
Instead of changing the behavior based on an isReportsPage prop, which is difficult to understand without delving in here, maybe we can add a headingLevel={3} prop. It would work like this ...
const Header = `h${headingLevel}`
return (
// ...
<Header>
Header content
</Header>
)There was a problem hiding this comment.
Thanks for that, been seeing this sprinkled around! We could make general component for this pattern now. Also updated in 9eb5875.
howard-e
force-pushed
the
support-v2-test-format
branch
from
133ed89 to
8dd8119
Compare
howard-e
force-pushed
the
v2-test-format-reports
branch
from
08194df to
38bec5f
Compare
alflennik
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #744. Based on #840.
This PR does the following:
The other items seem to already be addressed.