Address PR feedback

w3c · Nov 21, 2023 · 9eb5875 · 9eb5875
1 parent d9d7ff8
commit 9eb5875
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/client/components/Reports/SummarizeTestPlanReport.jsx b/client/components/Reports/SummarizeTestPlanReport.jsx
@@ -255,7 +255,10 @@ const SummarizeTestPlanReport = ({ testPlanVersion, testPlanReports }) => {
                                 key={`TestPlanResultsTable__${testResult.id}`}
                                 test={{ ...test, at }}
                                 testResult={testResult}
-                                isReportsPage={true}
+                                optionalHeader={
+                                    <h3>Results for each command</h3>
+                                }
+                                commandHeadingLevel={4}
                             />
                         </ResultsContainer>
 

diff --git a/client/components/common/TestPlanResultsTable/index.jsx b/client/components/common/TestPlanResultsTable/index.jsx
@@ -18,12 +18,14 @@ const TestPlanResultsTable = ({
     test,
     testResult,
     tableClassName = '',
-    isReportsPage = false
+    optionalHeader = null,
+    commandHeadingLevel = 3
 }) => {
+    const Heading = `h${commandHeadingLevel}`;
+
     return (
         <>
-            {isReportsPage ? <h3>Results for each command</h3> : null}
-
+            {optionalHeader}
             {testResult.scenarioResults.map((scenarioResult, index) => {
                 const passedAssertions = scenarioResult.assertionResults.filter(
                     assertionResult => assertionResult.passed
@@ -63,19 +65,11 @@ const TestPlanResultsTable = ({
 
                 return (
                     <React.Fragment key={scenarioResult.id}>
-                        {isReportsPage ? (
-                            <h4>
-                                {commandsString}&nbsp;Results:&nbsp;
-                                {passedAssertions.length} passed,&nbsp;
-                                {failedAssertions.length} failed
-                            </h4>
-                        ) : (
-                            <h3>
-                                {commandsString}&nbsp;Results:&nbsp;
-                                {passedAssertions.length} passed,&nbsp;
-                                {failedAssertions.length} failed
-                            </h3>
-                        )}
+                        <Heading>
+                            {commandsString}&nbsp;Results:&nbsp;
+                            {passedAssertions.length} passed,&nbsp;
+                            {failedAssertions.length} failed
+                        </Heading>
                         <p className="test-plan-results-response-p">
                             {test.at?.name} Response:
                         </p>
@@ -151,7 +145,8 @@ TestPlanResultsTable.propTypes = {
         scenarioResults: PropTypes.array.isRequired
     }),
     tableClassName: PropTypes.string,
-    isReportsPage: PropTypes.bool
+    optionalHeader: PropTypes.node,
+    commandHeadingLevel: PropTypes.number
 };
 
 export default TestPlanResultsTable;