Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchEvent is non cancelable yet checks canceled flag #741

Closed
nikhilm opened this issue Aug 31, 2015 · 3 comments
Closed

FetchEvent is non cancelable yet checks canceled flag #741

nikhilm opened this issue Aug 31, 2015 · 3 comments

Comments

@nikhilm
Copy link
Contributor

nikhilm commented Aug 31, 2015

Spec "Create a trusted event e that uses the FetchEvent interface, with the event type fetch, which does not bubble, is not cancelable, and has no default action."

But later "If event's canceled flag is set, then:

Set eventCanceled to true.

"

The DOM spec says preventDefault() can only set the canceled flag if the event is cancelable. 1

So cancelable or not cancelable?

@nikhilm
Copy link
Contributor Author

nikhilm commented Sep 3, 2015

@jungkees @jakearchibald

@jungkees
Copy link
Collaborator

jungkees commented Sep 4, 2015

@nikhilm I'll respond it after checking our previous discussion in the repo. Thanks for spotting this!

@jungkees
Copy link
Collaborator

jungkees commented Sep 4, 2015

FetchEvent should be cancelable: #51 (comment). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants