Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating reserved clients #1215

Closed
jakearchibald opened this issue Oct 25, 2017 · 9 comments
Closed

Navigating reserved clients #1215

jakearchibald opened this issue Oct 25, 2017 · 9 comments
Milestone

Comments

@jakearchibald
Copy link
Contributor

What happens if .navigate() is called on a reserved client (from resultingClientId)?

Failing in this case seems like the simplest thing to do. In this case the developer could navigate the replacesClientId.

@jakearchibald
Copy link
Contributor Author

Alternatively, if .navigate() is called on a reserved client, we could try and redirect that call to the associated client that would be replaced.

This association doesn't exist right now, but it may be developer-friendly to create it.

@wanderview
Copy link
Member

I think we decided that it should reject over here? #1034 (comment)

I guess the F2F note does not mention the navigate() method itself, just the properties.

@jakearchibald
Copy link
Contributor Author

I thought we discussed it, but couldn't find the comment. I'll leave this open so we confirm at the f2f, but yeah I think rejecting is the right choice.

@wanderview
Copy link
Member

Yea, I'd much rather expose the target client ID and let script redirect to their request there themselves instead of trying to do some kind of auto-magical mapping cross-process.

@jungkees jungkees reopened this Oct 26, 2017
@jungkees
Copy link
Collaborator

Misclicked.

I agree to reject on reserved client.

@jakearchibald
Copy link
Contributor Author

#1216 could remove this problem

@jungkees
Copy link
Collaborator

jungkees commented Nov 2, 2017

#1216 could remove this problem

And #1034, #1035.

@jakearchibald
Copy link
Contributor Author

Makes it sounds like a good idea 😄

@jakearchibald
Copy link
Contributor Author

We aren't going to expose reserved clients, so this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants