-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify that Client "creation order" means when reserved Client created #1078
Comments
That sounds good to me. One thing I want to think about is the case where an execution ready client (i.e. an environment settings object) that has never been focused may have been created EDIT: s/earlier/later/ |
Sorry, I don't follow. Can you give me an example? |
Sorry about the confusion first of all. I edited my comment above using a strikethrough: s/earlier/later/. Basically, I was concerned about the case where I think I'd have to dig into the definition of focused, focusable area and such more, but this is the scenario I was thinking about: SW A, B, and C for the same origin with different scopes are running. SW C running matchAll() captures the following state:
The matchAll() from SW C returns [ .. , windowClient_A, windowClient_B, ..] even though windowClient_A is still reserved and windowClient_B is execution ready. |
Yea, I think this is ok. Most callers won't see this since you have to opt-in to reserved clients. |
Or we could sort reserved clients to the back of the list, and then creation order within reserved clients. |
F2F: Reserved client creation time is fine. We should look into how to spec it. |
We aren't going to expose reserved clients, so this is no longer an issue. |
The
Clients.matchAll()
method says to sort Clients in creation order (among other things). I just want to confirm this means the sorted by the time the reserved client was created. Alternatively, it could mean when the environment backing the Client actually became Execution Ready.I favor the reserved client creation time because it provides a reasonable sort order for reserved clients included in the list.
The text was updated successfully, but these errors were encountered: