Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use value names which aren’t tied to UI affordance for FedCM parameter: mode #5

Closed
tttzach opened this issue Sep 12, 2024 · 2 comments

Comments

@tttzach
Copy link

tttzach commented Sep 12, 2024

We are proposing to rename the values that the mode parameter takes from button and widget to active and passive respectively.

await navigator.credentials.get({
  identity: {
    providers: [{
      // ...
    }],
    mode: "active" // defaults to "passive"
  }
});

The reasoning behind this is we feel the names button and widget are too tied to browser UI implementation whereas active and passive better represent the behavior of the FedCM API when these modes are specified.

  • active implies getting the user to login more actively and if they are currently logged out, we would show a more prominent UI gated behind user activation.
  • passive implies getting the user to login more passively and if they are currently logged out, we wouldn’t show any UI (modulo the login status API). This is the default value.

This parameter can also be extended to include other modes, if needed. We are open to hearing any and all thoughts.

@timcappalli
Copy link

Let's discuss at TPAC during the harmonization breakout session: w3c/tpac2024-breakouts#49

@samuelgoto
Copy link
Collaborator

We discussed this issue in the last CG call and got no objections to rename mode=button/widget to mode=active/passive.

I'm going to rename this repo and the rest of the documentation as a result. Chrome is going to start to implement this change too.

Let's discuss at TPAC during the harmonization breakout session: w3c/tpac2024-breakouts#49

I tried to write down @bvandersloot-mozilla 's argument here #6, so that I can close this issue with the convergence that we got at the CG meeting to rename from button/widget to active/passive mode, and we can follow up on the TPAC harmonization session and #6 separately.

Closing, let me know if there is something that I failed to capture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants