Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples showing an exchange client sending different VPRs with only acceptedCryptosuites or acceptedEnvelopes #399

Open
dlongley opened this issue Jul 16, 2024 · 1 comment
Labels
ready for PR Issue ready to be resolved via a Pull Request

Comments

@dlongley
Copy link
Contributor

In the examples, each with VPR should accept any VC that will have one or more matching cryptosuites, per "acceptedCryptosuites", or one matching envelope per "acceptedEnvelopes".

The example should show that a client (e.g., wallet) can start an exchange (if the server supports it) by sending a VPR indicating what they will accept instead of an empty object ({}):

// in this example, the client will accept a number of options from the issuer
{
  "verifiablePresentationRequest": {
    "query": {
      "type": "QueryByExample",
      // allows any VC(s) from the issuer, so no specific "credentialQuery" property;
      // "credentialQuery" ... not present
      "acceptedCryptosuites": [
        "Ed25519Signature2020",
        "eddsa-rdfc-2022",
        "ecdsa-rdfc-2019",
        "bbs-2023",
        "ecdsa-sd-2023"
      ],
      "acceptedEnvelopes": [
        "application/jwt"
      ]
    }
  }
}
// in this example, the client will accept only an enveloped VC using VC-JWT
{
  "verifiablePresentationRequest": {
    "query": {
      "type": "QueryByExample",
      // allows any VC(s) from the issuer, so no specific "credentialQuery" property;
      // "credentialQuery" ... not present
      "acceptedEnvelopes": [
        "application/jwt"
      ]
    }
  }
}
@msporny
Copy link
Contributor

msporny commented Jul 23, 2024

The group discussed this on the 2024-07-23 call:

@dlongley noted that starting an exchange only supports accepting an empty object. We need to support an exchange providing information on what cryptosuites and envelopes it might support (at a minimum), but more generally, we need to support sending an arbitrary VPR so the server can know what to send.

Raise a PR that modifies the OAS to allow an arbitrary VPR to be sent from the client to the server.

@msporny msporny added the ready for PR Issue ready to be resolved via a Pull Request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for PR Issue ready to be resolved via a Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants