Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All examples should use valid postal codes and valid area codes for real towns, with fake street addresses and fake local phone numbers #427

Open
TallTed opened this issue Jun 7, 2022 · 6 comments
Labels
good first issue Good for newcomers post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr

Comments

@TallTed
Copy link
Contributor

TallTed commented Jun 7, 2022

I believe I've supplied sufficient detail on individual cases for the general rules to be clear (e.g., 555-01xx local numbers within North America; other regions will have other reserved local ranges), but let me know if not.

@TallTed TallTed changed the title All examples should use valid postal codes and valid area codes for real towns, with fake street addresses and local phone numers All examples should use valid postal codes and valid area codes for real towns, with fake street addresses and fake local phone numbers Aug 16, 2022
@BenjaminMoe
Copy link
Contributor

BenjaminMoe commented Nov 1, 2022

In cases of cities: area code can be real. Local code should always be ###-555-####.
Specifically with test over data, we don't want tests that run over example data would cause a real number to ring.

@nissimsan
Copy link
Collaborator

Awaiting volunteers to pick this up.

@nissimsan nissimsan added the good first issue Good for newcomers label Apr 4, 2023
@TallTed
Copy link
Contributor Author

TallTed commented Aug 15, 2023

Learned recently -- ChatGPT can be used to generate sample data for a schema/ontology/vocabulary. It will only consume small-ish documents, but large docs can be fed via https://chatgptsplitter.com/.

@rhofvendahl
Copy link
Collaborator

Going through and looking up postal code and area code for every location would take some time, and I'm not confident the benefits would be worth it. Is the idea that having arbitrary codes would confuse software working with the data? Having written some scripts like this I wouldn't blindly trust the legitimacy of the examples regardless.

The ChatGPT example generation does look very interesting and potentially awesome for our examples, but I doubt their codes would line up either and it seems like that'd belong in a separate issue.

@TallTed
Copy link
Contributor Author

TallTed commented Aug 16, 2023

I doubt their codes would line up either

Why do you doubt this?

@rhofvendahl rhofvendahl removed their assignment Aug 16, 2023
@rhofvendahl
Copy link
Collaborator

I was about to say that I generally don't use gpt for anything factual or specific, but gpt4 just gave me 10 fictional addresses along with appropriate postal codes and area codes - color me impressed!

That makes this a bit less time consuming, but I personally I don't have the bandwidth so am un-assigning myself.

@mkhraisha mkhraisha added the post-1.0 This is for issues that are important but should not block 1.0 label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers post-1.0 This is for issues that are important but should not block 1.0 ready-for-pr
Projects
None yet
Development

No branches or pull requests

5 participants