Add overflow protection to num256 functions #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to add comments to what I added to make it easier to understand. |
DavidKnott
force-pushed
the
add-uint256-overflow-protection
branch
from
a1f39ce
to
39be5a8
Compare
|
@jacqueswww I added comments, please check this out when you have a sec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added overflow protection to
num256functions.- How I did it
I did this by looking at Solidity's
SafeMath.soland writing it inLLL.- How to verify it
Look at the tests I added, especially the ones that fail because of overflow.
- Description for the changelog
Add num256 overflow protection
- Cute Animal Picture