Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting - 9th April 2018 #753

Closed
jacqueswww opened this issue Apr 3, 2018 · 5 comments
Closed

Meeting - 9th April 2018 #753

jacqueswww opened this issue Apr 3, 2018 · 5 comments
Labels
meeting Meeting

Comments

@jacqueswww
Copy link
Contributor

jacqueswww commented Apr 3, 2018

Meeting Details

General Bi-Weekly meeting.
Start: Monday 9th April 2018, 14:00 UTC (https://time.is/UTC)
Hangouts: https://meet.google.com/czc-kuep-jda

Agenda

@jacqueswww
Copy link
Contributor Author

jacqueswww commented Apr 3, 2018

Feel free to comment any additional agenda items here.

@ben-kaufman
Copy link
Contributor

Not sure I will be able to join the call.
Anyway I think we should add #752 to the VIP Discussions.

@jacqueswww jacqueswww changed the title Meeting 3/4/2018 Meeting - 9th April 2018 Apr 3, 2018
@yzhang90
Copy link

yzhang90 commented Apr 6, 2018

Improving shift function.

shift is compiled to the following code:

   ['if', ['sle', '_s', 0], 
          ['div', '_v', ['exp', 2, ['sub', 0, '_s']]], 
          ['mul', '_v', ['exp', 2, '_s']]]]],

When _s == 0, ['div', '_v', ['exp', 2, ['sub', 0, '_s']]] and ['mul', '_v', ['exp', 2, '_s']]]] are the same. But in the div branch, it need to execute sub which potentially costs more gas. Suggest using slt instead of sle. This will also ease the verification. On the other hand, EIP145 proposes supporting shift opcode directly in EVM. Not sure when it will happen.

@jacqueswww
Copy link
Contributor Author

@yzhang90 Please create the two tickets/bugs you have discovered, much appreciated 😄

@jacqueswww
Copy link
Contributor Author

@jacqueswww jacqueswww added the meeting Meeting label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting Meeting
Projects
None yet
Development

No branches or pull requests

3 participants