Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift argument type inconsistencies #3309

Closed
xrchz opened this issue Mar 5, 2023 · 1 comment
Closed

shift argument type inconsistencies #3309

xrchz opened this issue Mar 5, 2023 · 1 comment

Comments

@xrchz
Copy link
Contributor

xrchz commented Mar 5, 2023

Version Information

  • vyper Version (output of vyper --version): 0.3.8+commit.8ebabc5c
  • OS: GNU
  • Python Version (output of python --version): Python 3.10.9

What's your issue about?

This file compiles fine with vyper, but fails if you try to load it with boa.

@external
def bug() -> uint256:
  x: uint256 = 392
  y: uint256 = 19
  return shift(x, y)

The docs for shift list the following type:
shift(x: uint256, _shift: int128) → uint256

The implementation is different again, allowing any integer type (whereas boa complains for non-int128).

How can it be fixed?

Decide on the semantics and make vyper, boa, and the docs consistent.

@charles-cooper
Copy link
Member

closing as this was an issue with boa's vyper pin being out of date. also, shift() is deprecated as of #3019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants