-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: jupyterlab extension #83
Comments
also debugger (cf. https://jupyterlab.readthedocs.io/en/stable/user/debugger.html) and kernel for vyper could be done |
Is the idea here to simply port the existing code into a proper plugin, or do we want to add/change the functionality as well? |
i think first port into a plugin, and then we can talk about adding additional functionality. the real issue that i'm trying to address here is that the way of jerry-rigging the required libraries that works for jupyter notebook does not work for jupyter labs. |
I created a plugin template in https://github.com/DanielSchiavini/titanoboa-jupyterlab Update dec 5: trying to figure out how to add a comm target from the frontend. The kernel is not directly available like before. Alternatevely we could implement some other 2 way communication via ipython or tornado, but that's much more cumbersome. |
very slick! i think i have a couple reservations about using |
btw, does this technique work with google colab somehow? |
We definitely don't need any extra dependencies, this was an easy way to proof the concept. |
I replaced the shared dict dependency with a SharedMemory object for each of the expected callbacks. DanielSchiavini/titanoboa-jupyterlab@2e86d6b |
The integration tests are failing in Github for some stupid reason (they pass locally). Of course we could ignore the included tests, but the pipelines are vital to easily produce a npm+pip package. |
I have 2 PRs with the implementation ready for review: |
it would be cool to have https://github.com/vyperlang/titanoboa/blob/2c2a2664ad3fa566ddda8a43851cd6f14ab9276a/boa/integrations/jupyter.py work with jupyterlab (on account of jupyterlab being the new thing, it has an IDE and workspace etc). the current method for loading
ethers
does not seem to work though, it fails withrequire not defined
, seems to be related to Calysto/calysto_processing#11 (comment). it looks like the thing to do is write a proper jupyterlab extension, which would be cool too since we could support vyper files natively.The text was updated successfully, but these errors were encountered: