-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnosis safe implementation #120
Comments
brownie-safe has call traces in their Also, there are implementations to sign with trezor or frame or ledger etc. whereas i think we should simply stick to browsersigner in this case. let users use notebooks to sign transactions, post them, fetch status on pending transactions, execute transactions etc. |
The other issue I see with this is: if we integrate safe into boa, we would need to import web3py and that's going to bloat boa. |
i don't see why that would be the case. besides, it should probably be a separate package anyways. |
The api I recommend is: with boa.safe.build_transaction():
coin.approve(safe, 2**256-1)
safe.spend(coin, 10**18)
coin.approve(safe, 0) |
is this issue ready? |
cf. https://pypi.org/project/ape-safe/
https://github.com/banteg/brownie-safe#readme
The text was updated successfully, but these errors were encountered: