From 8b7a356e01fba4110dcf118c0fdd291d006654d1 Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Mon, 14 Oct 2024 16:26:39 +0000 Subject: [PATCH] Move workflow to nightly and fix static configure parameters --- .github/workflows/pr.yaml | 8 -------- .github/workflows/test.yaml | 14 +++++++++++++- ci/clang_tidy.sh | 2 +- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 4119c5f3a28..bc237cc73b0 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -14,8 +14,6 @@ jobs: needs: - changed-files - checks - # TODO: Before merging this PR, this check needs to be moved to nightly.yaml - - clang-tidy - conda-cpp-build - conda-cpp-checks - conda-cpp-tests @@ -96,12 +94,6 @@ jobs: uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-24.12 with: enable_check_generated_files: false - clang-tidy: - secrets: inherit - uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.12 - with: - build_type: pull-request - run_script: "ci/clang_tidy.sh" conda-cpp-build: needs: checks secrets: inherit diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index a22d3c5b9cc..1275aad757c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -47,11 +47,23 @@ jobs: secrets: inherit uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.12 with: - build_type: pull-request + build_type: nightly + branch: ${{ inputs.branch }} + date: ${{ inputs.date }} + sha: ${{ inputs.sha }} # Use the wheel container so we can skip conda solves and since our # primary static consumers (Spark) are not in conda anyway. container_image: "rapidsai/ci-wheel:latest" run_script: "ci/configure_cpp_static.sh" + clang-tidy: + secrets: inherit + uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@branch-24.12 + with: + build_type: nightly + branch: ${{ inputs.branch }} + date: ${{ inputs.date }} + sha: ${{ inputs.sha }} + run_script: "ci/clang_tidy.sh" conda-python-cudf-tests: secrets: inherit uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-24.12 diff --git a/ci/clang_tidy.sh b/ci/clang_tidy.sh index 93e5624e43b..4d5d3fc3136 100755 --- a/ci/clang_tidy.sh +++ b/ci/clang_tidy.sh @@ -3,7 +3,7 @@ set -euo pipefail -rapids-logger "Create checks conda environment" +rapids-logger "Create clang-tidy conda environment" . /opt/conda/etc/profile.d/conda.sh ENV_YAML_DIR="$(mktemp -d)"