Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11] Fix line search comparisons #12

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[#11] Fix line search comparisons #12

merged 1 commit into from
Feb 9, 2021

Conversation

vvpisarev
Copy link
Owner

Bracketing and zoom phases now do comparisons the same way.

Should fix #11

@vvpisarev vvpisarev requested a review from stepanzh February 9, 2021 14:31
@vvpisarev vvpisarev linked an issue Feb 9, 2021 that may be closed by this pull request
Bracketing phase in linsearch does not account for possible numerical errors #11
Open
stepanzh
stepanzh approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@stepanzh stepanzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@vvpisarev vvpisarev merged commit 6d8f8c5 into dev Feb 9, 2021
@vvpisarev vvpisarev deleted the issue11 branch February 9, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanzh stepanzh stepanzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bracketing phase in linsearch does not account for possible numerical errors
2 participants
@vvpisarev @stepanzh