Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] unable to swap from ETH.ARB to RUNE #1177

Closed
realpaaao opened this issue Oct 15, 2024 · 2 comments
Closed

[BUG] unable to swap from ETH.ARB to RUNE #1177

realpaaao opened this issue Oct 15, 2024 · 2 comments
Assignees
@johnnyluo
Labels
bug 🐞 Something isn't working
Milestone
Release 1.0.29

Comments

@realpaaao
Copy link
Contributor

Describe the bug
When trying to sign swap from ETH.ARB to RUNE the keysign is not possible

Expected behavior
Able to swap over this route

Screenshots
Image

  • Version 29
@realpaaao realpaaao added the bug 🐞 Something isn't working label Oct 15, 2024
@realpaaao realpaaao added this to the Release 1.0.29 milestone Oct 15, 2024
@johnnyluo
Copy link
Contributor

https://github.com/vultisig/vultisig-android/blob/main/app/src/main/java/com/vultisig/wallet/ui/models/swap/SwapFormViewModel.kt#L272
for Mayaswap , we should use quote.data.inboundAddress , currently can't deal with quote.data.router

@johnnyluo johnnyluo mentioned this issue Oct 16, 2024
Merged
@johnnyluo johnnyluo self-assigned this Oct 16, 2024
@realpaaao
Copy link
Contributor Author

QA done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnyluo johnnyluo

Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
Release 1.0.29
Development

No branches or pull requests
2 participants
@johnnyluo @realpaaao