Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: key shouldn't undefined for link entries #158

Closed
TheAlexLichter opened this issue Nov 10, 2022 · 2 comments
Closed

Types: key shouldn't undefined for link entries #158

TheAlexLichter opened this issue Nov 10, 2022 · 2 comments

Comments

@TheAlexLichter
Copy link
Contributor

Reproduction code:

<script setup lang="ts">
useHead({
  link: [{ rel: 'icon', key: 'favicon', href: 'SOME_STRING' }],
});
</script>
<template>
  <div>
    <h1>Hi</h1>
  </div>
</template>

Expected: key should be fine as string or ref/computed/... returning one

Actual:

image

@TheAlexLichter TheAlexLichter changed the title Types: key is undefined for link entries. Types: key shouldn't undefined for link entries Nov 10, 2022
@harlan-zw
Copy link
Collaborator

Thanks for the issue. This was legacy logic around key handling, for some reason links were excluded and I wasn't prepared to break anything to allow them.

This is fixed in v1, I'll leave this open until it's officially released

@harlan-zw
Copy link
Collaborator

v1 looking good, going to close this off

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants