Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add expanded slot transition to VDataTable #8197

Closed
Pazza opened this issue Jul 30, 2019 · 10 comments · May be fixed by #16773
Closed

[Feature Request] Add expanded slot transition to VDataTable #8197

Pazza opened this issue Jul 30, 2019 · 10 comments · May be fixed by #16773
Assignees
Labels
C: VDataTable VDatatable T: feature A new feature

Comments

@Pazza
Copy link

Pazza commented Jul 30, 2019

Environment

Vuetify Version: 2.0.3
Last working version: 2.0.0-beta.5
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Mac OS 10.14.5

Steps to reproduce

Create a data-table with an expanded-item slot.

Expected Behavior

apply v-expand-transition

Actual Behavior

No transition.

Reproduction Link

https://codepen.io/pazza/pen/ZgKQNa

Other comments

Including the v-expand-transition element manually does not produce expected result.

Documentation for v-expand-transition states that it is used in this application.

@nekosaur
Copy link
Member

I forgot to add this to the upgrade guide. Transition was removed for 2.0. The solution in 1.5 required us to define both tr and td (with a colspan equal to header length), always show this row with height zero until transition was triggered, and place the slot inside all of this. It meant that developers had no way of defining individual columns in expanded row, and that we were always showing expanded rows (so things like css nth-child(odd/even) did not work as expected).

Some kind of userland solution should be possible, although it might require a few tweaks from our end. I will try to investigate.

@zherman91
Copy link

Hello @nekosaur,
Is there any update on this by chance? I am running into the same issue. Any help provided is greatly appreciated. Thanks!

@Webifi
Copy link
Contributor

Webifi commented Oct 24, 2019

Looking for an update on this as well. I'm migrating an old Vuetify 1.x app to 2.x and the client was disappointed that the expand transition on v-data-table was missing.

Tried a few methods of getting a transition after/before the creation/removal of the expanded content but, especially when using single-expand, I really can't find a great way to deal with it.

@nekosaur
Copy link
Member

Unfortunately I have not had time to look into user land solutions.

@Webifi
Copy link
Contributor

Webifi commented Oct 24, 2019

Thanks.

I've managed to bolt something on, but it's far too ugly and overly complicated for me to want to show here. Involves timeouts and implementing single-expand in "user land" instead of using Vuetify's.

Seems like it would be much cleaner for it to be implemented in vuetify rather than having to hack something on.

@Webifi
Copy link
Contributor

Webifi commented Oct 24, 2019

It's not pretty, but here's an example of how I did it:
https://codepen.io/webifi/pen/ExxmXbJ?editors=1010

@johnleider johnleider changed the title [Bug Report] VDataTable Expanded-Item slot not transitioning [Feature Request] Add expanded slot transition to VDataTable Nov 21, 2019
@johnleider johnleider added T: feature A new feature and removed S: triage labels Nov 21, 2019
@johnleider
Copy link
Member

As this was intentionally removed, marking as a feature. Also this does not work on 2.0.0-beta.5.

@cvidalsastre
Copy link

cvidalsastre commented Nov 28, 2019

having the same issue
Is there a solution for this problem?
i tried using the transition component but isn't working ;S

@Webifi
Copy link
Contributor

Webifi commented Nov 29, 2019

@peronvidal See my codepen example above. It's a bit more complicated than just using the transition component.

@EJMarrero
Copy link

EJMarrero commented Feb 24, 2023

Is there any update about this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable VDatatable T: feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants