-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass template refs to slots as functions #19731
Conversation
@@ -327,3 +327,5 @@ export type ComponentInstance<T> = T extends { new (): ComponentPublicInstance<a | |||
type ShortEmitsToObject<E> = E extends Record<string, any[]> ? { | |||
[K in keyof E]: (...args: E[K]) => any; | |||
} : E; | |||
|
|||
export type FunctionVNodeRef = (ref: Element | ComponentPublicInstance | null, refs: Record<string, any>) => void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VOverlay does this too, maybe others. |
Issue could happen to all slots whose props contain template ref, I found 3 places, they all have console errors when running in dev playground
Not sure whether date-picker-year worth to fix or not, because it's unlikely two appear the same time in a loop |
Temporarily upgrade to
"vue": "^3.4.25"
in dev playground to replicate the issueVue reproduction link
fixes #19713
fixes #19685
Description
Markup: