Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VDataTable): add mobile view #19431

Merged
merged 79 commits into from
Apr 29, 2024

Conversation

webdevnerdstuff
Copy link
Contributor

@webdevnerdstuff webdevnerdstuff commented Mar 19, 2024

Description

Adds a mobile view for the data tables

Ref Issue: #16784

Markup:

<template>
  <v-data-table
    v-model:expanded="expanded"
    :fixed-header="true"
    :headers="headers"
    :items="desserts"
    :mobile="smAndDown"
    :multi-sort="false"
    item-value="name"
    items-per-page="5"
    theme="dark"
    show-expand
    show-select
  >
    <template #[`header.name`]>
      name header slot
    </template>
    <template #[`item.calories`]>
      calories item slot
    </template>
    <template #expanded-row="{ index, columns }">
      <tr>
        <td :colspan="columns.length">
          Index: {{ index }} Expanded Row
        </td>
      </tr>
    </template>
  </v-data-table>
</template>

<script setup lang="ts">
  import { ref } from 'vue'
  import { useDisplay } from 'vuetify'

  const { smAndDown } = useDisplay()

  const expanded = ref([])
  const headers = ref([
    {
      title: 'Dessert (100g serving)',
      align: 'start',
      sortable: false,
      key: 'name',
    },
    { title: 'Calories', key: 'calories' },
    { title: 'Fat (g)', key: 'fat' },
    { title: '', key: 'data-table-expand' },
  ] as const)
  const desserts = ref([
    {
      name: 'Frozen Yogurt',
      calories: 159,
      fat: 6,
    },
    {
      name: 'Ice cream sandwich with some really long name',
      calories: 237,
      fat: 9,
    },
    {
      name: 'Eclair',
      calories: 262,
      fat: 16,
    },
    {
      name: 'Cupcake',
      calories: 305,
      fat: 3.7,
    },
    {
      name: 'Gingerbread',
      calories: 356,
      fat: 16,
    },
    {
      name: 'Jelly bean',
      calories: 375,
      fat: 0,
    },
    {
      name: 'Lollipop',
      calories: 392,
      fat: 0.2,
    },
    {
      name: 'Honeycomb',
      calories: 408,
      fat: 3.2,
    },
    {
      name: 'Donut',
      calories: 452,
      fat: 25,
    },
    {
      name: 'KitKat',
      calories: 518,
      fat: 26,
    },
  ])
</script>

@webdevnerdstuff webdevnerdstuff changed the title feat/data table mobile view feat(VDataTable): Adds a mobile view for data tables Mar 19, 2024
@MajesticPotatoe MajesticPotatoe added T: feature A new feature C: VDataTable VDatatable labels Mar 19, 2024
@MajesticPotatoe
Copy link
Member

Rebase to dev

@johnleider johnleider requested review from KaelWD, johnleider and a team March 19, 2024 21:33
@webdevnerdstuff webdevnerdstuff force-pushed the feat/data-table-mobile-view branch from 3f6a19c to 69273b8 Compare March 20, 2024 02:57
johnleider
johnleider previously approved these changes Apr 27, 2024
@yuwu9145
Copy link
Member

  • Missing "select all" checkbox
  • Item checkbox is left-aligned

V2 mobile screenshot (white background) is attached for comparison

Screenshot 2024-04-28 at 11 36 22 am Screenshot 2024-04-28 at 11 43 37 am

@webdevnerdstuff
Copy link
Contributor Author

I fixed the alignment to be end for the checkbox. As for the header one, I'll chat with John about what to do with that, as personally I think it looks kind of weird next to the sortby.

@johnleider johnleider merged commit 66880ce into vuetifyjs:dev Apr 29, 2024
10 checks passed
@boobo94
Copy link

boobo94 commented May 18, 2024

Does anyone know how can I overwrite the default 52px row height on mobile? Because the content overflows. I tried to check in the documentation, but couldn't find something.

Screenshot 2024-05-18 at 14 25 28

@chudson-incomm
Copy link

chudson-incomm commented May 20, 2024

I think you will have to override the CSS for mobile in this instance.

Something like this...

tbody .v-data-table__tr--mobile > td {
min-height: 60px !important;
}

Assuming this is a slot that adds buttons. You may want to evaluate if mobile breakpoint has been hit and turn the buttons into icon only to shrink down the content if it provides a better mobile experience as well.

@webdevnerdstuff Any other way to handle this issue? I am not sure if it would be a feature...

@boobo94
Copy link

boobo94 commented May 20, 2024

I think you will have to override the CSS for mobile in this instance.

Something like this...

tbody .v-data-table__tr--mobile > td { min-height: 60px !important; }

Assuming this is a slot that adds buttons. You may want to evaluate if mobile breakpoint has been hit and turn the buttons into icon only to shrink down the content if it provides a better mobile experience as well.

@webdevnerdstuff Any other way to handle this issue? I am not sure if it would be a feature...

Thanks for your reply.

I already added a CSS rule:

.v-data-table__row-height-auto :deep(.v-data-table__tr--mobile) > td {
  height: fit-content;
}

I was curious if there's something else available from config. I checked the PR, but I found nothing related. So I hoped there was something.

@webdevnerdstuff
Copy link
Contributor Author

webdevnerdstuff commented May 20, 2024

@cjhudson101 I'm pretty sure I had accounted for adjustable height depending on the content.

Added a PR to fix it: #19843

@chudson-incomm
Copy link

chudson-incomm commented May 21, 2024

@boobo94 The change was included in this morning's 3.6.7 release.

@boobo94
Copy link

boobo94 commented May 21, 2024

Soo cool. thanks!

@boobo94 The change was included in this morning's 3.6.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDataTable VDatatable T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants