Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.2.2] v-label sass variables don't work #17302

Closed
mwshub opened this issue May 5, 2023 · 3 comments
Closed

[Bug Report][3.2.2] v-label sass variables don't work #17302

mwshub opened this issue May 5, 2023 · 3 comments
Assignees
Labels
C: VLabel VLabel Component T: bug Functionality that does not work as intended/expected
Milestone

Comments

@mwshub
Copy link

mwshub commented May 5, 2023

Environment

Vuetify Version: 3.2.2
Vue Version: 3.2.47
Browsers: Firefox 112.0
OS: Windows 10

Steps to reproduce

  1. add v-checkbox, v-radio, v-label, etc.
  2. modify variables such as $label-color, $label-disabled-color, $label-error-color and $label-letter-spacing in settings.scss.

Expected Behavior

The color of the text will be changed.

Actual Behavior

The spacing between letters has been increased, but the colors have not been changed.

Reproduction Link

https://stackblitz.com/edit/vitejs-vite-dw77gf?file=src/App.vue

Other comments

The current color of the text is too light, which is why I need to customize the color.

Related to #16928.

@lioneaglesolutions
Copy link
Collaborator

$label-color: rgba(var(--v-theme-on-surface), var(--v-medium-emphasis-opacity)) !default;

$label-disabled-color: rgba(var(--v-theme-on-surface), var(--v-disabled-opacity)) !default;

$label-error-color: rgb(var(--v-theme-error)) !default;

It looks like there were a few other variables introduced in https://github.com/vuetifyjs/vuetify/pull/14359/files#diff-6e2ab35094d273d04f94386767bad15de636d9daacf92de5125b46d6a3065dda

I can see they were used in this merge into next;
https://github.com/vuetifyjs/vuetify/pull/14359/files#diff-f6b0995d964f4e5cf4eb1e3f1ee04d4fdef5a8586974c8a7092ad6f113bd9dd8R22

But I can't seem to follow it from there to see if/where they were removed.

@lioneaglesolutions
Copy link
Collaborator

Okay I can see they were removed in ae01ce4 but the Sass variables remain. To me error/disabled/color should be control by the theme and the new defaults, not Saas variables so I assume the variables just need to be removed - @johnleider any insights on this one?

@lioneaglesolutions lioneaglesolutions added the C: VLabel VLabel Component label May 8, 2023
@MaxenceMouchard
Copy link

I spent a long time trying to understand how sass variables worked with vuetify. Now I see that it's just an inconsistency or a bug ...

Like @mwshub I confirm that the override of a variable such as $label-color makes absolutely no visual difference, which is not the case with $label-font-size, which works as expected, for example.

A component such as label, so simple and useful, shouldn't be reporting this kind of problem. It would be reassuring if this kind of issue could be handled.

@johnleider johnleider self-assigned this Aug 31, 2023
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Aug 31, 2023
@johnleider johnleider added this to the v3.3.x milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VLabel VLabel Component T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants