Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flex): add new classes #16820

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat(flex): add new classes #16820

merged 2 commits into from
Apr 20, 2023

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Mar 2, 2023 •
edited
Loading

Motivation and Context

Adds the following classes with responsive support:

  • flex-1-1
  • flex-1-0
  • flex-0-1
  • flex-0-0
  • flex-1-1-100
  • flex-1-0-100
  • flex-0-1-100
  • flex-0-0-100

@johnleider johnleider self-assigned this Mar 2, 2023
@johnleider johnleider added the T: feature A new feature label Mar 2, 2023
@johnleider johnleider added this to the v3.2.0 (Orion) milestone Mar 2, 2023
@johnleider johnleider merged commit bce1b07 into dev Apr 20, 2023
@johnleider johnleider deleted the feat/add-flex-classes branch April 20, 2023 14:16
KaelWD
KaelWD reviewed Apr 20, 2023
View reviewed changes
packages/vuetify/src/styles/settings/_utilities.scss
values: (fill: 1 1 auto)
values: (
fill: 1 1 auto,
'1-1': 1 1 auto,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicates fill

packages/vuetify/src/styles/settings/_utilities.scss
fill: 1 1 auto,
'1-1': 1 1 auto,
'1-0': 1 0 auto,
'0-1': 0 1 auto,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default value

packages/vuetify/src/styles/settings/_utilities.scss
'1-1': 1 1 auto,
'1-0': 1 0 auto,
'0-1': 0 1 auto,
'0-0': 0 0 auto,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-none?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelWD KaelWD KaelWD left review comments

Assignees

@johnleider johnleider

Labels
T: feature A new feature
Projects
None yet
Milestone
v3.2.0 (Orion)
Development

Successfully merging this pull request may close these issues.
2 participants
@johnleider @KaelWD