Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTooltip): add eager prop support #16752

Merged
merged 2 commits into from
Feb 28, 2023
Merged

feat(VTooltip): add eager prop support #16752

merged 2 commits into from
Feb 28, 2023

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Feb 22, 2023

Motivation and Context

For performance reasons this should have eager support. Tested with 250 tooltips. Reduced render time by almost 50%.

Eager Avg Render Time
true 280ms
false 143ms

Markup:

<template>
  <v-app>
    <div class="ma-4 pa-4">
      <template v-for="n in 100" :key="n">
        <v-tooltip :eager="false">
          <template #activator="{ props }">
            <button v-bind="props">Tooltip</button>
          </template>

          Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
        </v-tooltip>
      </template>

    </div>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'
</script>

currently is always forced on
@johnleider johnleider added T: feature A new feature C: VTooltip VTooltip labels Feb 22, 2023
@johnleider johnleider self-assigned this Feb 22, 2023
@johnleider johnleider requested a review from KaelWD February 22, 2023 19:28
@johnleider johnleider marked this pull request as ready for review February 24, 2023 21:42
@johnleider johnleider added this to the v3.1.x milestone Feb 28, 2023
@johnleider johnleider merged commit d0761be into dev Feb 28, 2023
@johnleider johnleider deleted the feat/tooltip-eager branch February 28, 2023 16:55
guilhermesdev pushed a commit to guilhermesdev/vuetify that referenced this pull request Mar 19, 2023
johnleider added a commit to SteinRobert/vuetify that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTooltip VTooltip T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant