From a194622437e9baa0e9202a349fbc97dee95885cf Mon Sep 17 00:00:00 2001 From: WebDevNerdStuff Date: Thu, 2 May 2024 19:55:33 -0700 Subject: [PATCH] fix(VDataTable): change mobile default to false (#19744) Co-authored-by: John Leider --- packages/api-generator/src/locale/en/display.json | 4 ++-- .../src/components/VNavigationDrawer/VNavigationDrawer.tsx | 2 +- packages/vuetify/src/composables/display.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/api-generator/src/locale/en/display.json b/packages/api-generator/src/locale/en/display.json index 1fea0af1766..22b1639681f 100644 --- a/packages/api-generator/src/locale/en/display.json +++ b/packages/api-generator/src/locale/en/display.json @@ -1,6 +1,6 @@ { "props": { - "mobile": "Explicitly designate as a mobile display configuration.", - "mobileBreakpoint": "Overrides the display configuration default." + "mobile": "Determines the display mode of the component. If true, the component will be displayed in mobile mode. If false, the component will be displayed in desktop mode. If null, will be based on the current mobile-breakpoint", + "mobileBreakpoint": "Overrides the display configuration default screen size that the component should be considered in mobile." } } diff --git a/packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.tsx b/packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.tsx index 55fb512e9bb..ef077b7c8da 100644 --- a/packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.tsx +++ b/packages/vuetify/src/components/VNavigationDrawer/VNavigationDrawer.tsx @@ -87,7 +87,7 @@ export const makeVNavigationDrawerProps = propsFactory({ ...makeBorderProps(), ...makeComponentProps(), ...makeDelayProps(), - ...makeDisplayProps(), + ...makeDisplayProps({ mobile: null }), ...makeElevationProps(), ...makeLayoutItemProps(), ...makeRoundedProps(), diff --git a/packages/vuetify/src/composables/display.ts b/packages/vuetify/src/composables/display.ts index eee63db72b6..98e1416ea27 100644 --- a/packages/vuetify/src/composables/display.ts +++ b/packages/vuetify/src/composables/display.ts @@ -216,8 +216,8 @@ export function createDisplay (options?: DisplayOptions, ssr?: SSROptions): Disp export const makeDisplayProps = propsFactory({ mobile: { - type: Boolean, - default: null, + type: Boolean as PropType, + default: false, }, mobileBreakpoint: [Number, String] as PropType, }, 'display')