Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fonts): @mdi/font version #240

Merged
merged 2 commits into from
Mar 1, 2021
Merged

fix(fonts): @mdi/font version #240

merged 2 commits into from
Mar 1, 2021

Conversation

ElijahKotyluk
Copy link
Contributor

@ElijahKotyluk ElijahKotyluk commented Feb 27, 2021 •
edited
Loading

resolves: #238

@ElijahKotyluk ElijahKotyluk self-assigned this Feb 27, 2021
@ElijahKotyluk ElijahKotyluk added the enhancement New feature or request label Feb 27, 2021
@ElijahKotyluk ElijahKotyluk marked this pull request as ready for review February 27, 2021 09:48
@ElijahKotyluk ElijahKotyluk changed the title fix(fonts): bump @mdi/font version. fix(fonts): @mdi/font version. Feb 27, 2021
johnleider
johnleider requested changes Feb 27, 2021
View reviewed changes
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason behind changing all of the quotations?

@ElijahKotyluk
Copy link
Contributor Author

I need to update my vscode settings to not run prettier or lint when saving I think. Definitely wasn’t intentional lol.

@johnleider johnleider changed the title fix(fonts): @mdi/font version. fix(fonts): @mdi/font version Mar 1, 2021
@johnleider johnleider merged commit ac2c30c into master Mar 1, 2021
@johnleider johnleider deleted the fix/238-mdi-font-dep branch March 1, 2021 20:32
@nanpx nanpx mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees

@ElijahKotyluk ElijahKotyluk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Fonts as a dependency option does not work
2 participants
@ElijahKotyluk @johnleider